Skip to content

Merge Develop into Master (v1.32) - #2528

Merged
Didayolo merged 41 commits into
masterfrom
develop
Sep 18, 2026
Merged

Didayolo merged 41 commits into
masterfrom
develop

Conversation

@ObadaS

@ObadaS ObadaS commented Sep 1, 2026

Copy link
Copy Markdown
Collaborator

@Didayolo Didayolo added the Release PR develop --> master label Sep 8, 2026
wlln and others added 25 commits September 8, 2026 12:14
Forbid the compute worker from pulling competition images
Paginate the competition list endpoint (LargePagination), and update
the Organizing/Participating tabs in competition_list.tag to
consume the new {count, next, previous, results} shape with
next/previous buttons (hidden on a single page). Fix the navbar
competition search to read response.results instead of assuming a
bare array.

Fix participating_in filter incorrectly including competitions the
user organizes: creators/collaborators are auto-added as approved
participants (Competition.save()), so they leaked into the
Participating tab. Applied the same fix to the public competitions
endpoint's participating_in filter and updated its tests. Added
coverage for the list endpoint's pagination and participating_in
behavior. Minor renames for clarity (change_page, tab labels).
Add pagination to GET /api/competitions and fix participating_in leak
…limit

Raise RAM limit for Site Worker in docker-compose.yml
…t is reached. Fixed user lookup to not show deleted users in the collaborators dropdown
Remove the is_bot user flag and allow_robot_submissions competition setting, along with the permission bypasses they granted (unlimited submissions, auto-approval as participant, and unrestricted re-run/secret-check bypass on any submission). Also removes the related UI, docs, and tests.
Remove robot submissions and bot user feature
…titions

Propagate organization when creating chiled submissions during multi-task split, phase migration, and re-run so that leaderboard entries for organization submissions on multi-task competitions show the organization name instead of falling back to the submitter's username.
Fix organization name not showing on leaderboard for multi-task competitions
Anonymous and non-owner requests could previously view submission
details when hide_output was off. Now only the owner or an admin
can access them. Adds tests covering the fix.
Submission `get_detail` API: Restrict to submission owner or admin
@cjh1

cjh1 commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

Do we have a timeline for v1.32? There are several fixes we are interested in.

@ObadaS

ObadaS commented Sep 10, 2026

Copy link
Copy Markdown
Collaborator Author

Do we have a timeline for v1.32? There are several fixes we are interested in.

We are hoping to merge it next week, most likely on Wednesday.
Are the fixes already merged or are you interested in one of the currently unmerged ones ?

@cjh1

cjh1 commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

Do we have a timeline for v1.32? There are several fixes we are interested in.

We are hoping to merge it next week, most likely on Wednesday. Are the fixes already merged or are you interested in one of the currently unmerged ones ?

Great thank you, no the ones we want are merged.

@cjh1

cjh1 commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

@ObadaS, Would it be possible to get #2536 in the release as well?

ObadaS and others added 2 commits September 14, 2026 15:47
* switch to quay.io for mc and minio images

* Update documentation

---------

Co-authored-by: Obada Haddad <obada.haddad@lisn.fr>
Co-authored-by: didayolo <adrien.pavao@gmail.com>
* Deny anonymous access to /api/submissions/ list and retrieve

Anonymous GETs returned full submission records (filenames, status
details, fact sheet answers) for any finished leaderboard submission,
ignoring is_public. Now returns an empty queryset instead; public
leaderboard data is already served by get_leaderboard in PhaseViewSet

* Add missing raise

* Fix test and remove debug prints

---------

Co-authored-by: didayolo <adrien.pavao@gmail.com>
@Didayolo

Copy link
Copy Markdown
Member

@ObadaS, Would it be possible to get #2536 in the release as well?

Done!

@cjh1

cjh1 commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

@ObadaS, Would it be possible to get #2536 in the release as well?

Done!

Great, thank you!

ObadaS and others added 6 commits September 15, 2026 16:23
* update djangorestframework in pyproject and packages in uv.lock with uv lock --upgrade

* update boto3 (removed s3transfer and botocore, they are dependencies), update gunicorn and uvicorn to latest

* update packages in pyproject

* update django-oauth-toolkit and related packages

* update dompurify

* add DOMPurify to marked

---------

Co-authored-by: Obada Haddad <obada.haddad@lisn.fr>
…#2496)

* Enforce phase start/end window on submission creation

Phase.is_active returned True unconditionally when end was unset,
never checking start — a not-yet-started phase with no end date was
treated as active. SubmissionCreationSerializer.validate() also never
checked is_active or can_user_make_submissions(), so submissions could
be created via the API before a phase started or after it ended.

- Fix Phase.is_active to check start regardless of whether end is set
- Reject submission creation when the target phase is not active or
  the user has hit their submission limit, returning a 400 error
- Add tests for both new fixes

* Fix flake8

---------

Co-authored-by: didayolo <adrien.pavao@gmail.com>
* Add External Competitions feature: aggregate competitions from other Codabench/CodaLab instances

New app — external_competitions
- Models: ExternalPlatform (a registered remote instance), ExternalCompetition (a fetched competition), ExternalFetchLog (per-sync audit trail with SUCCESS/PARTIAL_SUCCESS/FAILURE status, counts, and error messages)
- admin.py registrations for all three models with list filters/search
- Initial migration

Fetchers
- fetchers/codabench_fetcher.py — paginated fetch from a Codabench instance's public competitions API, with a page-fetch throttle and a MAX_PAGES safety cap
- fetchers/codalab_fetcher.py — flat-list fetch from a CodaLab instance
- fetchers/exceptions.py — PartialFetchError, letting a fetcher hand back whatever it collected before a later page failed

Sync task
- fetch_sync.py — fetch_external_competitions Celery task (feature-flag gated, scheduled daily via CELERY_BEAT_SCHEDULE) and sync_platform, which diffs fetched data against the DB (create/update/delete), skipping the delete step on a partial fetch to avoid dropping valid competitions from unfetched pages

API
- api/serializers/external_competitions.py — ExternalCompetitionSerializer, ExternalPlatformFilterSerializer
- api/views/external_competitions.py — list view with search/platform filtering, and an unpaginated platforms list for the filter UI
- api/urls.py — both routes registered only when EXTERNAL_COMPETITIONS_ENABLED is on

Frontend
- external_competitions/urls.py + views.py + templates/external_competitions/public.html — the public page route
- static/riot/external_competitions/external_competition_list.tag — the competition list/filter/pagination UI
- client.js — API helpers for the two new endpoints
- public-list.tag — banner linking to the External Competitions page (shown only when the feature is enabled)
- base.html / context_processors.py — expose the feature flag and public URL to the frontend

Settings
- EXTERNAL_COMPETITIONS_ENABLED flag (settings/base.py, .env_sample), off by default
- external_competitions added to INSTALLED_APPS

Test data
- factories.py — ExternalPlatformFactory, ExternalCompetitionFactory

Tests
- external_competitions/tests/test_fetchers.py — unit tests for both fetchers (pagination, throttling, MAX_PAGES, error propagation, partial-fetch handling)
- external_competitions/tests/test_fetch_sync.py — unit tests for sync_platform/fetch_external_competitions (create/update/delete diffing, partial-success handling, per-platform failure isolation)
- api/tests/test_external_competitions.py — API tests for both endpoints, plus flag-gated URL registration tests

Documentation
- New External-Competitions.md page: enabling the flag, admin fields, sync mechanics, and registration/unregistration instructions for other platform maintainers
- zensical.toml nav entry
- Tip added to the deploy guide pointing self-hosters at registering their instance

* flake-8 fixes

* registration instructions added to external competitions page

* renamed fetch_sync.py to tasks.py so that celery can run the task periodically, updated codabench fetcher to not use the next url from the response but instead use a page counter for next page, related updates to docs and tests

* ui updates to differentiate external page from public page.

* Some small fixes

* Fix spinner

* Avoid duplicated CSS

---------

Co-authored-by: didayolo <adrien.pavao@gmail.com>
Compute worker workaround for API throttling
…es to Codabench (#2460)

* add option in compute worker env to not send logs to the instance, instead writing them in a local file

* rename the No Cleanup env variable, add documentation

* use real boolean values

* update logs_loguru to inclue new tasks variable names to color them

* change variable name to use boolean

* fix some syntax

* add option to forbid the compute worker from sending predictions to the codabench instance storage

* add better coloration for some logs in the compute worker

* update documentation

* add error when copying failes when in no prediction upload mode

---------

Co-authored-by: Obada Haddad <obada.haddad@lisn.fr>
@Didayolo
Didayolo marked this pull request as ready for review September 17, 2026 12:29
@ObadaS
ObadaS requested a review from IdirLISN September 18, 2026 09:07
@Didayolo
Didayolo merged commit 1bc61b8 into master Sep 18, 2026
2 checks passed
@cjh1

cjh1 commented Sep 18, 2026

Copy link
Copy Markdown
Contributor

Thanks everyone for getting these changes in 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Release PR develop --> master

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants